Prefer drupal namespace in Composer. #1020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2270
Other Relevant Links
What does this Pull Request do?
Changes Islandora module to use the
drupal
composer namespace.What's new?
Rename the module to
drupal/islandora
. This alone should have the effect of making it inaccessible to peoplerequire
ingislandora/islandora
... therefore:Added a
replace
directive that says this package replaces islandora/islandora. This should make this package available to anyone who isrequire
ingislandora/islandora
, so long as they have the Drupal module repository in their composer file (and surely they must)Changed our requirement for
islandora/jsonld
todrupal/jsonld
.Does this change add any new dependencies? It changes how an existing dependency is required.
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)? No!
Could this change impact execution of existing code? No.
How should this be tested?
[Help needed! It's not clear to me how to test this except to make a custom version of the starter site and require this branch? ]
With this PR, you should be able to get an islandora spun up (based on a starter site altered to remove the islandora/islandora dependency) and it would only have drupal/islandora.
With this PR merged, existing sites should not have a problem loading islandora/islandora or drupal/islandora.
[should we eventually mark packagist deprecated and suggest drupal/islandora?]
A description of what steps someone could take to:
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers