Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plinth] Optimize 'unionValue' #6590

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3900182104674
| mem: 3900000902990})
({cpu: 3900163753050
| mem: 3900000790184})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 5700263611088
| mem: 5700001377860})
({cpu: 5700216220216
| mem: 5700001087342})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4700192221958
| mem: 4700000967314})
({cpu: 4700174302334
| mem: 4700000857208})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9% CPU speedup and 12% MEM speedup for such a low-hanging fruit.

Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500158228140
| mem: 3500000774178})
({cpu: 3500146900516
| mem: 3500000705272})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3700178626534
| mem: 3700000879296})
({cpu: 3700163064494
| mem: 3700000785186})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500166448956
| mem: 3500000810828})
({cpu: 3500150449332
| mem: 3500000712722})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500165287257
| mem: 3500000804226})
({cpu: 3500149287633
| mem: 3500000706120})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4700203854488
| mem: 4700001024508})
({cpu: 4700181482032
| mem: 4700000889094})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4100191466863
| mem: 4100000955552})
({cpu: 4100170032823
| mem: 4100000824742})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4100175265212
| mem: 4100000864518})
({cpu: 4100158204380
| mem: 4100000760410})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4300195205954
| mem: 4300000974510})
({cpu: 4300172523914
| mem: 4300000835900})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4300196350641
| mem: 4300000988686})
({cpu: 4300170682185
| mem: 4300000832672})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 5300231219760
| mem: 5300001186638})
({cpu: 5300208254928
| mem: 5300001045630})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500162680962
| mem: 3500000795700})
({cpu: 3500146713338
| mem: 3500000697794})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3700175160808
| mem: 3700000864572})
({cpu: 3700162819976
| mem: 3700000789964})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500155811252
| mem: 3500000746522})
({cpu: 3500146862044
| mem: 3500000691220})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4300195357672
| mem: 4300000990758})
({cpu: 4300165113216
| mem: 4300000806144})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4100169551218
| mem: 4100000837290})
({cpu: 4100156148802
| mem: 4100000754786})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3900172439569
| mem: 3900000866110})
({cpu: 3900155367945
| mem: 3900000761304})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4900197144622
| mem: 4900000999410})
({cpu: 4900179038206
| mem: 4900000887506})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3700165927838
| mem: 3700000818434})
({cpu: 3700147827006
| mem: 3700000707826})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4100184202568
| mem: 4100000917228})
({cpu: 4100168325736
| mem: 4100000820520})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3900182104674
| mem: 3900000902990})
({cpu: 3900163753050
| mem: 3900000790184})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4100193313124
| mem: 4100000968548})
({cpu: 4100167271084
| mem: 4100000808938})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500164835516
| mem: 3500000800230})
({cpu: 3500153443892
| mem: 3500000730924})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500161996210
| mem: 3500000789306})
({cpu: 3500150636586
| mem: 3500000720200})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500165984574
| mem: 3500000808726})
({cpu: 3500149984950
| mem: 3500000710620})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500161519187
| mem: 3500000789098})
({cpu: 3500145551563
| mem: 3500000691192})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4100180427916
| mem: 4100000888646})
({cpu: 4100163335084
| mem: 4100000784338})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3700173474723
| mem: 3700000850386})
({cpu: 3700153208683
| mem: 3700000726876})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11.5% CPU speedup and 15% MEM speedup.

Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4100182559737
| mem: 4100000909620})
({cpu: 4100161061697
| mem: 4100000778410})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500164835516
| mem: 3500000800230})
({cpu: 3500153443892
| mem: 3500000730924})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500158215499
| mem: 3500000776072})
({cpu: 3500142279875
| mem: 3500000678366})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3700175322846
| mem: 3700000866270})
({cpu: 3700159792806
| mem: 3700000772360})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500162680886
| mem: 3500000795700})
({cpu: 3500146713262
| mem: 3500000697794})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500162680886
| mem: 3500000795700})
({cpu: 3500146713262
| mem: 3500000697794})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4300198689156
| mem: 4300000999356})
({cpu: 4300177985532
| mem: 4300000871850})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3900168250190
| mem: 3900000826656})
({cpu: 3900153354566
| mem: 3900000735450})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4700194863304
| mem: 4700000988954})
({cpu: 4700175295680
| mem: 4700000868548})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3900182104674
| mem: 3900000902990})
({cpu: 3900163753050
| mem: 3900000790184})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4500201093612
| mem: 4500001004874})
({cpu: 4500185664780
| mem: 4500000910966})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500164822875
| mem: 3500000802124})
({cpu: 3500148823251
| mem: 3500000704018})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500164822875
| mem: 3500000802124})
({cpu: 3500148823251
| mem: 3500000704018})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3700172019158
| mem: 3700000853244})
({cpu: 3700156521118
| mem: 3700000759534})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 5500221761286
| mem: 5500001141534})
({cpu: 5500195511246
| mem: 5500000980624})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4700207353582
| mem: 4700001047804})
({cpu: 4700173056294
| mem: 4700000840382})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3900175497298
| mem: 3900000876938})
({cpu: 3900157209674
| mem: 3900000764532})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500164822875
| mem: 3500000802124})
({cpu: 3500148823251
| mem: 3500000704018})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 5100237653524
| mem: 5100001233714})
({cpu: 5100200433068
| mem: 5100001005500})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4300195357672
| mem: 4300000990758})
({cpu: 4300165113216
| mem: 4300000806144})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3700172019158
| mem: 3700000853244})
({cpu: 3700156521118
| mem: 3700000759534})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 4700200490390
| mem: 4700001015184})
({cpu: 4700180890766
| mem: 4700000894578})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3900184661276
| mem: 3900000920286})
({cpu: 3900162885652
| mem: 3900000786080})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500161519187
| mem: 3500000789098})
({cpu: 3500145551563
| mem: 3500000691192})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500155811252
| mem: 3500000746522})
({cpu: 3500146862044
| mem: 3500000691220})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500164822875
| mem: 3500000802124})
({cpu: 3500148823251
| mem: 3500000704018})
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
({cpu: 3500165984574
| mem: 3500000808726})
({cpu: 3500149984950
| mem: 3500000710620})
Loading
Loading