[Builtins] Make unlifting lazy again #6434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/benchmark validation |
|
/benchmark nofib |
|
/benchmark lists |
|
Make your bets, is this going to happen again:
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on '4b8e137e1' (base) and 'd63521331' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
-2.3% in total. I don't trust it, probably just a glitch, let's see the next one. |
|
Comparing benchmark results of 'nofib' on '4b8e137e1' (base) and 'd63521331' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
-1.6% in total and I still don't believe it. Also note how the |
|
Comparing benchmark results of 'lists' on '4b8e137e1' (base) and 'd63521331' (PR) Results table
|
|
/benchmark lists |
2 similar comments
|
/benchmark lists |
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '4b8e137e1' (base) and 'd63521331' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '4b8e137e1' (base) and 'd63521331' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '4b8e137e1' (base) and 'd63521331' (PR) Results table
|
|
/benchmark validation |
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Click here to check the status of your benchmark. |
…to effectfully/builtins/make-unlifting-lazy-again
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'ce72537391' (base) and '6478b97e0e' (PR) Results table
|
|
/benchmark validation |
2 similar comments
|
/benchmark validation |
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'ce72537391' (base) and '6478b97e0e' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'ce72537391' (base) and '6478b97e0e' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
/benchmark validation |
1 similar comment
|
/benchmark validation |
|
Comparing benchmark results of 'validation' on 'ce72537391' (base) and '6478b97e0e' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'ce72537391' (base) and '6478b97e0e' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation' on 'ce72537391' (base) and '6478b97e0e' (PR) Results table
|
…to effectfully/builtins/make-unlifting-lazy-again
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
kwxm
approved these changes
Nov 29, 2024
| @@ -294,13 +294,29 @@ instance | |||
| -- See Note [One-shotting runtime denotations]. | |||
| -- Grow the builtin application within the received action and recurse on the result. | |||
| toMonoF getBoth = BuiltinExpectArgument . oneShot $ \arg -> | |||
| -- Ironically computing the unlifted value strictly is the best way of doing deferred | |||
There was a problem hiding this comment.
Ironically computing
This sounds like some kind of technique: "ironic computation". We should invent something just so we can call it that.
Co-authored-by: Kenneth MacKenzie <kenneth.mackenzie@iohk.io>
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Unisay
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a regression performance-wise, but we may already be charging for it (depends on how budgeting calibration works), so let's see, maybe it's not detectable regardless.