Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NodeToClientV_18 #4960

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Add NodeToClientV_18 #4960

merged 4 commits into from
Sep 20, 2024

Conversation

dnadales
Copy link
Member

@dnadales dnadales commented Sep 17, 2024 •
edited
Loading

Description

Add NodeToClientV_18 which is required to support the GetFuturePParams query.

See IntersectMBO/ouroboros-consensus#1204

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@dnadales dnadales requested a review from a team as a code owner September 17, 2024 16:40
@dnadales dnadales mentioned this pull request Sep 17, 2024
Merged
coot
coot approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnadales dnadales mentioned this pull request Sep 19, 2024
Closed
15 tasks
@dnadales dnadales force-pushed the dnadales/1204-add-query-future-pparams branch from e0712ee to 92778e3 Compare September 19, 2024 10:29
crocodile-dentist
crocodile-dentist approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dnadales dnadales added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit 4ac087c Sep 20, 2024
14 checks passed
@dnadales dnadales deleted the dnadales/1204-add-query-future-pparams branch September 20, 2024 12:56
crocodile-dentist pushed a commit that referenced this pull request Sep 27, 2024
@dnadales @crocodile-dentist
Add NodeToClientV_18 (#4960)
3a34601 
* Add `NodeToClientV_18`

* Adapt `cardano-ping` to the addition of `NodeToClientV_18`

* Add changelog entries

* Add new version number to the `.cddl` spec
crocodile-dentist pushed a commit that referenced this pull request Oct 3, 2024
@dnadales @crocodile-dentist
Add NodeToClientV_18 (#4960)
51b82f0 
* Add `NodeToClientV_18`

* Adapt `cardano-ping` to the addition of `NodeToClientV_18`

* Add changelog entries

* Add new version number to the `.cddl` spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crocodile-dentist crocodile-dentist crocodile-dentist approved these changes

@coot coot coot approved these changes

Assignees

@dnadales dnadales

Labels
None yet
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnadales @coot @crocodile-dentist