BlockFetch: fix EBB edge case in plausibleCandidateChain
#1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
requested review from
nfrisby,
jasagredo,
fraser-iohk and
dnadales
as code owners
jasagredo
approved these changes
Nov 14, 2024
amesgen
force-pushed
the
amesgen/fix-plausibleChain-ebbs
branch
from
3fcb740
to
f1aa2b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #67 for more context on this error. We have seen this error quite often recently, I am not yet sure why, this can/should be investigated separately. The slightly more complicated logic definitely outweighs the negative experience of dealing with flaky tests.
Seed that shows that this PR fixes the problem: