Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hackage resource-registry #1291

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Use hackage resource-registry #1291

merged 2 commits into from
Oct 23, 2024

Conversation

jasagredo
Copy link
Contributor

Extract the resource-registry from the codebase. As it is independent from strict-checked-vars some instances are needed for this to work properly, in particular:

-- TVar
instance NoThunks (Control.Concurrent.Class.MonadSTM.Strict.StrictTVar m a)
instance NoThunks (Control.Concurrent.Class.MonadSTM.Strict.StrictTVar m a)
      => NoThunks (Ouroboros.Consensus.Util.NormalForm.StrictTVar.StrictTVar m a)

-- MVar
instance NoThunks (Control.Concurrent.Class.MonadMVar.Strict.StrictMVar m a)
instance NoThunks (Control.Concurrent.Class.MonadMVar.Strict.StrictMVar m a)
      => NoThunks (Ouroboros.Consensus.Util.NormalForm.StrictMVar.StrictMVar m a)

Then as we sometimes use checked or unchecked vars, both constraints (which will be logically implied but on QuantifiedConstraints GHC can't know that) are required in IOLike.

@jasagredo jasagredo changed the base branch from js/hackage-rawlock to main October 23, 2024 21:20
@jasagredo jasagredo added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit decf7f5 Oct 23, 2024
13 checks passed
@jasagredo jasagredo deleted the js/resource-registry branch October 23, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants