Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a race condition in RWVar #433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix a race condition in RWVar #433

wants to merge 2 commits into from

Commits on Nov 14, 2024

  1. Find an RWVar race condition using IOSimPOR. 

    `prop_noRace` is updated to properly test interleavings of threads, and threads
can now be cancelled asynchronously. This unearths a subtle race condition in
`unsafeAcquireWriteAccess`, which contains interruptible operations that leave
the internal state of `RWVar` in an unrecoverable state if they happen in just
the right place.
    @jorisdral
    jorisdral committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a13308f View commit details
    Browse the repository at this point in the history

  2. Fix the race condition in unsafeAcquireWriteAccess. 

    This mainly involves rolling back previous `RWState` changes if an interrupt
happens. The code is extended with comments to explain how the code is now
interrupt-safe.
    @jorisdral
    jorisdral committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e4affc9 View commit details
    Browse the repository at this point in the history