Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks and small fixes to the prototype #310

Merged
merged 10 commits into from
Aug 20, 2024
Merged

Tweaks and small fixes to the prototype #310

merged 10 commits into from
Aug 20, 2024
+242 −104

Commits on Aug 20, 2024

  1. refactor prototype

    @mheinzel
    mheinzel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a414034 View commit details
    Browse the repository at this point in the history

  2. unify style of invariant 

    This way we always know the exact assertion that failed.
    @mheinzel
    mheinzel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ab10233 View commit details
    Browse the repository at this point in the history

  3. add test for merging underfull run again with incoming ones

    @mheinzel
    mheinzel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6fa93c4 View commit details
    Browse the repository at this point in the history

  4. increase size for prototype lockstep test

    @mheinzel
    mheinzel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    22f88b4 View commit details
    Browse the repository at this point in the history

  5. fix run size invariants that were too tight

    @mheinzel
    mheinzel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c76b0a9 View commit details
    Browse the repository at this point in the history

  6. tighten invariants

    @mheinzel
    mheinzel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8071d62 View commit details
    Browse the repository at this point in the history

  7. fix calculation of merge debt 

    The adjustment of the calculation is necessary to avoid assertion
failures for the new assertion.
    @mheinzel
    mheinzel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ef61d4f View commit details
    Browse the repository at this point in the history

  8. prototype: supply 1.25 credits for 5-way tiering merges 

    This is necessary when holding back runs that are too small.
    @mheinzel
    mheinzel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6f15601 View commit details
    Browse the repository at this point in the history

  9. check invariant after supplying credits

    @mheinzel
    mheinzel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    77c4bb4 View commit details
    Browse the repository at this point in the history

  10. make assertions on LSM shape in prototype tests

    @mheinzel
    mheinzel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    44a8cd4 View commit details
    Browse the repository at this point in the history