Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it build with ghc-9.8 #192

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Make it build with ghc-9.8 #192

merged 4 commits into from
Nov 16, 2023

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Aug 28, 2023

No description provided.

@erikd erikd force-pushed the erikd/ghc-9.8 branch 2 times, most recently from 80512ef to 631e470 Compare August 29, 2023 01:20
@erikd erikd marked this pull request as draft August 31, 2023 02:41
@erikd erikd force-pushed the erikd/ghc-9.8 branch 4 times, most recently from 4bdb0c9 to c74c619 Compare October 10, 2023 02:54
@erikd erikd force-pushed the erikd/ghc-9.8 branch 2 times, most recently from ce40a6e to 6bb3911 Compare October 11, 2023 23:34
@erikd erikd force-pushed the erikd/ghc-9.8 branch 2 times, most recently from d21512c to 256d6be Compare November 15, 2023 19:51
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins
Copy link
Contributor

lehins commented Nov 15, 2023

@erikd
Copy link
Contributor Author

erikd commented Nov 15, 2023

@lehins Using:

        cabal-version: latest

trys to install 3.6.2.0 and that fails.

@lehins
Copy link
Contributor

lehins commented Nov 15, 2023

Change this line to haskell-actions/setup@v2:
https://github.com/input-output-hk/cardano-prelude/blob/39a4235a2502a621da96648da88aa6fc6c1efaeb/.github/workflows/haskell.yml#L22

* Use latest cabal instead of a specific version
* Add ghc-9.8.1
* Bust cache
* Switch to `haskell-actions/setup@v2`
@angerman
Copy link
Contributor

LGTM. #193 tries to address the nix related issues.

@angerman angerman merged commit 0e12f09 into master Nov 16, 2023
12 of 52 checks passed
@angerman angerman deleted the erikd/ghc-9.8 branch November 16, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants