-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script that reads cabal's plan.json (and a CHaP index) and generates a markdown table of links to changelogs for each package #5415
Conversation
Love this, time permitting I'll have a look today. Note that foliage produces a json file with the repository metadata along with the repository itself (in |
ba51120
to
aea3ce3
Compare
Thanks for taking a look!
Do you mean that the first GitHub lookup -- grabbing all relevant |
I was time pressed and I have been unclear. A https://input-output-hk.github.io/cardano-haskell-packages/foliage/packages.json
it contains the package part of meta.toml but, so far, not the revisions (see input-output-hk/foliage#44). Regarding nix vs not nix, the difference is incidental. Given how haskell.nix works today, it will fetch the whole git repository which hosts the website https://github.com/input-output-hk/cardano-haskell-packages/tree/repo, so it will fetch cabal will only fetch the 01-index.tar.gz file (and some other json files related to hackage-security), but of course you can just fetch it yourself. w.r.t the changelogs: no, we don't pass the package description (and therefore the extra-source-files) into package.json. Maybe we could? Your are welcome to open an issue on the foliage repo |
Ah, I understand what you mean now. You're right, it'd be easier to pull it from a built I should be able to make the script more resilient by parsing |
Added info about the script to the RELEASE.md script, and it now pulls package info from |
…rates a markdown table of links to changelogs for each package fix script so it builds on GHC 8.10.7 remove hardcoded github access token and add help to describe how it can be generated / retrieved detect CHaP packages based on "is this not from hackage?" rather than "is this from CHaP?" to accomodate nix-built plan.jsons hlint fixes stylish-haskell formatting add information about the script to RELEASE.md look for package versions using foliage/packages.json rather than meta.tomls remove mention of cardano-haskell-packages from RELEASE.md, since we're now using packages.json
11ed96d
to
6b485a5
Compare
Description
meta.toml
for each package-version pair to find its GitHub repository / revision / subdirectoryCHANGELOG.md
-looking file in that directory on GitHub (using its API)Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.