Simplify working with current epoch number #4767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/avoid-computing-current-epochNo
branch
from
f3520aa
to
5a45f60
Compare
lehins
force-pushed
the
lehins/avoid-computing-current-epochNo
branch
from
5a45f60
to
eec0386
Compare
lehins
force-pushed
the
lehins/avoid-computing-current-epochNo
branch
from
eec0386
to
75c789f
Compare
Placement of `epochInfoEpoch`, `epochInfoFirst` and `epochInfoSize` in a reader monad was superfluous. Another improvement is making current epoch number lazy in the environment, because that information is not necessary for all types of transactions
lehins
force-pushed
the
lehins/avoid-computing-current-epochNo
branch
from
75c789f
to
e872b4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Placement of
epochInfoEpoch,epochInfoFirstandepochInfoSizein a reader monad was superfluous.Another improvement is making current epoch number lazy in the environment, because that information is not necessary for all types of transactions
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)