Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registered DRep stake distribution query #4764

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Nov 20, 2024

Description

Resolves #4664

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor Author

@Lucsanszky Lucsanszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a rough initial draft but the main logic is there and hopefully it's generally correct. I added a question as I need some clarification on how to tackle the AlwaysAbstain and NoConfidence DReps.

@Lucsanszky Lucsanszky force-pushed the ldan/drep-distr-query-optimisation branch 3 times, most recently from 4e986ed to 2039d95 Compare November 20, 2024 19:26
@Lucsanszky Lucsanszky marked this pull request as ready for review November 20, 2024 19:26
@Lucsanszky Lucsanszky requested a review from a team as a code owner November 20, 2024 19:26
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small mistakes, but other than that it is exactly what we needed.

@Lucsanszky Lucsanszky force-pushed the ldan/drep-distr-query-optimisation branch from d1eec85 to 18a08e4 Compare November 21, 2024 05:54
@Lucsanszky Lucsanszky changed the title Add efficient DRep stake distribution query Add registered DRep stake distribution query Nov 21, 2024
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you!

@Lucsanszky Lucsanszky merged commit 242547e into master Nov 21, 2024
154 checks passed
@Lucsanszky Lucsanszky deleted the ldan/drep-distr-query-optimisation branch November 21, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a query for current DRep delegations and stake distribution
2 participants