-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cardano-base dependency #4699
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tdammers Please get rid of any changes related to serialization.
I wish you would have asked me before you went on wasting a lot of time on introducing all those changes.
We need to get rid of all KES related serialization form ledger, since ledger codebase does not depend on KES at all. So, please revert all of the additions with respect to KES and get rid of any serialization functionality for KES that was provided before
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/RoundTripSpec.hs
Outdated
Show resolved
Hide resolved
cd58e1d
to
e2f0944
Compare
890a734
to
f1c33e4
Compare
15f7ecd
to
c33d9da
Compare
c33d9da
to
41a6cef
Compare
41a6cef
to
12d29c9
Compare
This now passes hydra CI but fails to build locally with |
12d29c9
to
d0828b1
Compare
d0828b1
to
1048b45
Compare
Description
Upgrade dependency on
cardano-base
in order to be compatible with upcoming versions ofouroboros-consensus
.In current versions of
cardano-base
, KES sign keys are stored in mlocked memory, and all operations involving them must now happen inIO
orST
. In order to facilitate existing pure code that isn't security-critical (e.g., generating mock data for testing purposes), the previous pure KES API is now provided asUnsoundPureKES
, which we use here.Checklist
CHANGELOG.md
for the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)