Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cardano-base dependency #4699

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tdammers
Copy link

Description

Upgrade dependency on cardano-base in order to be compatible with upcoming versions of ouroboros-consensus.
In current versions of cardano-base, KES sign keys are stored in mlocked memory, and all operations involving them must now happen in IO or ST. In order to facilitate existing pure code that isn't security-critical (e.g., generating mock data for testing purposes), the previous pure KES API is now provided as UnsoundPureKES, which we use here.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdammers Please get rid of any changes related to serialization.
I wish you would have asked me before you went on wasting a lot of time on introducing all those changes.

We need to get rid of all KES related serialization form ledger, since ledger codebase does not depend on KES at all. So, please revert all of the additions with respect to KES and get rid of any serialization functionality for KES that was provided before

@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 5 times, most recently from cd58e1d to e2f0944 Compare October 31, 2024 04:08
@lehins lehins changed the base branch from master to lehins/update-index-state October 31, 2024 15:08
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 2 times, most recently from 890a734 to f1c33e4 Compare October 31, 2024 16:36
Base automatically changed from lehins/update-index-state to master October 31, 2024 20:35
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 2 times, most recently from 15f7ecd to c33d9da Compare October 31, 2024 21:23
@neilmayhew neilmayhew force-pushed the tdammers/for-mlocked-kes-consensus branch from c33d9da to 41a6cef Compare November 13, 2024 05:07
@neilmayhew neilmayhew force-pushed the tdammers/for-mlocked-kes-consensus branch from 41a6cef to 12d29c9 Compare November 16, 2024 00:20
@neilmayhew
Copy link
Contributor

This now passes hydra CI but fails to build locally with nix develop and cabal. The Add a workaround the fact plutus-tx-plugin is "special" commit makes the local build work but causes a true nix build to fail. We will probably need help from DevX to solve this.

@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch from 12d29c9 to d0828b1 Compare November 20, 2024 00:13
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch from d0828b1 to 1048b45 Compare November 20, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants