1843 - limit cache when close to tip #1886
Open
+180
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmdv
force-pushed
the
1843-limit-cache-at-tip
branch
3 times, most recently
from
c3e80f5
to
73a8fa6
Compare
Cmdv
force-pushed
the
1843-limit-cache-at-tip
branch
from
73a8fa6
to
34bceb6
Compare
kderme
requested changes
Nov 25, 2024
| -- cPools, cPrevBlock, Cstats, cEpoch | ||
| pure c | ||
| else pure c | ||
| optimiseCaches c = pure c |
There was a problem hiding this comment.
Possibly you can pattern match on a ActiveCache False cache, to avoid this duplicate pure c case.
| atomically $ | ||
| writeTVar (cStake ci) stakeCache' | ||
| pure $ Right stakeAddrsId | ||
| NoCache -> mapLeft (,bs) <$> resolveStakeAddress bs |
There was a problem hiding this comment.
Suggested change
| NoCache -> mapLeft (,bs) <$> resolveStakeAddress bs | |
| ActiveCache False ci -> do | |
| ... | |
| _ -> mapLeft (,bs) <$> resolveStakeAddress bs |
Merge the 2 states together
There was a problem hiding this comment.
They need to be different states because when ActiveCache False ci we still want to use cPools, cPrevBlock, Cstats, cEpoch caches. But when No Cache we don't use caches at all.
changed it to:
case cache of
NoCache -> mapLeft (,bs) <$> resolveStakeAddress bs
ActiveCache True _ -> mapLeft (,bs) <$> resolveStakeAddress bs
ActiveCache False ci -> do
...There was a problem hiding this comment.
When it's True, we don't need though. I think this is equivalent.
case cache of
ActiveCache False ci -> do
...
_ -> mapLeft (,bs) <$> resolveStakeAddress bs
| -- Update cache. | ||
| liftIO $ atomically $ modifyTVar (cTxIds cacheInternal) $ FIFO.insert txIdLedger txId | ||
| -- Return ID after updating cache. | ||
| ActiveCache isCacheOptomised cacheInternal -> do |
There was a problem hiding this comment.
Suggested change
| ActiveCache isCacheOptomised cacheInternal -> do | |
| ActiveCache False cacheInternal -> do | |
| ... | |
| _ -> DB.queryTxId txHash |
Same, merge the 2 states together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #1843
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.