Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate node-10 #1878

Merged
merged 7 commits into from
Oct 23, 2024
Merged

Integrate node-10 #1878

merged 7 commits into from
Oct 23, 2024

Conversation

kderme
Copy link
Contributor

@kderme kderme commented Oct 21, 2024

Description

Add your description here, if it fixes a particular issue please provide a link to the issue.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@kderme kderme marked this pull request as ready for review October 23, 2024 11:35
@kderme kderme requested review from a team as code owners October 23, 2024 11:35
Copy link
Contributor

@Cmdv Cmdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kderme kderme merged commit f08b9c5 into master Oct 23, 2024
17 of 19 checks passed
@@ -71,7 +71,7 @@ drepDistr =

newCommittee :: IOManager -> [(Text, Text)] -> Assertion
newCommittee =
withFullConfig conwayConfigDir testLabel $ \interpreter server dbSync -> do
withFullConfigAndLogs conwayConfigDir testLabel $ \interpreter server dbSync -> do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to commit this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants