Skip to content

Commit

Permalink
fix: The "Max _N_ items retrieved" message in c-select now accounts f…
Browse files Browse the repository at this point in the history
…or list calls that don't provide a count, e.g. by passing `noCount=true`.
  • Loading branch information
ascott18 committed Oct 2, 2024
1 parent bf2bdec commit d070ce2
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 5.0.4

- fix: The "Max _N_ items retrieved" message in c-select now accounts for list calls that don't provide a count, e.g. by passing `noCount=true`.

# 5.0.3

- fix: Remove flawed logic that chooses the wrong foreign key for navigation properties where the target type of the navigation property has a primary key that also serves as a foreign key in some other relationship. In exceedingly rare cases, you may now have to add a `[ForeignKey(Name = ...)]` attribute to any navigation properties that may now throw a codegen validation error that their foreign key property cannot be discovered automatically. Related to this issue, `ClassViewModel.IsOneToOne` is now deprecated and slated for future removal.
Expand Down
9 changes: 8 additions & 1 deletion src/coalesce-vue-vuetify3/src/components/input/c-select.vue
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,14 @@
<!-- TODO: With this version of c-select (versus the v2 one),
we can implement infinite scroll much easier. Consider doing this instead of having this message. -->
<v-list-item
v-if="listCaller.pageCount && listCaller.pageCount > 1"
v-if="
// When we do know an actual page count:
(listCaller.pageCount && listCaller.pageCount > 1) ||
// When `noCount` is used or counting is disabled on the server:
(listCaller.pageCount == -1 &&
listCaller.pageSize &&
listItems.length >= listCaller.pageSize)
"
class="text-grey font-italic"
>
Max {{ listCaller.pageSize }} items retrieved. Refine your search to
Expand Down

0 comments on commit d070ce2

Please sign in to comment.