Skip to content

Commit

Permalink
fix(vue3): don't allow defaults to override the variant of the search…
Browse files Browse the repository at this point in the history
… field in c-select, as some variants look bad, including `outlined` which will obscure the loading bar with the field's outline.
  • Loading branch information
ascott18 committed Aug 21, 2023
1 parent 1c48133 commit 09491c0
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
14 changes: 13 additions & 1 deletion playground/Coalesce.Web.Vue3/src/components/test.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
density="compact"
variant="outlined"
date-kind="datetime"
v-model="date" clearable
v-model="date"
clearable
/>
<c-datetime-picker
label="Date"
Expand Down Expand Up @@ -50,6 +51,17 @@
>
</c-select>

<v-defaults-provider
:defaults="{ VTextField: { variant: 'outlined', density: 'compact' } }"
>
<c-select
:model="caseVm"
for="assignedTo"
label="Outlined via v-defaults-provider"
>
</c-select>
</v-defaults-provider>

<img
v-if="caseVm.caseKey"
:src="caseVm.downloadImage.getResultObjectUrl()"
Expand Down
4 changes: 3 additions & 1 deletion src/coalesce-vue-vuetify3/src/components/input/c-select.vue
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
"
clearable
placeholder="Search"
variant="filled"
>
</v-text-field>
Expand All @@ -102,7 +103,8 @@
v-if="!createItemLabel && !listItems.length"
class="grey--text px-4 my-3 font-italic"
>
No results found.
<template v-if="listCaller.isLoading">Loading...</template>
<template>No results found.</template>
</div>
<!-- This height shows 7 full items, with a final item partially out
Expand Down

0 comments on commit 09491c0

Please sign in to comment.