refactor: sonar suggestions

BREAKING CHANGE: EventTag is now sealed
Informatievlaanderen · Nov 18, 2024 · 59e8a17 · 59e8a17
1 parent 95062c7
commit 59e8a17
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/src/Be.Vlaanderen.Basisregisters.EventHandling.Autofac/EventHandlingModule.cs b/src/Be.Vlaanderen.Basisregisters.EventHandling.Autofac/EventHandlingModule.cs
@@ -18,17 +18,17 @@ public EventHandlingModule(Assembly eventsAssembly, JsonSerializerSettings jsonS
             _eventMapping = new EventMapping(EventMapping.DiscoverEventNamesInAssembly(eventsAssembly));
         }
 
-        protected override void Load(ContainerBuilder containerBuilder)
+        protected override void Load(ContainerBuilder builder)
         {
-            containerBuilder
+            builder
                 .RegisterInstance(_eventMapping)
                 .As<EventMapping>();
 
-            containerBuilder
+            builder
                 .RegisterInstance(_eventDeserializer)
                 .As<EventDeserializer>();
 
-            containerBuilder
+            builder
                 .RegisterInstance(_eventSerializer)
                 .As<EventSerializer>();
         }

diff --git a/...Be.Vlaanderen.Basisregisters.EventHandling/Documentation/RegistryEventsMarkdownBuilder.cs b/...Be.Vlaanderen.Basisregisters.EventHandling/Documentation/RegistryEventsMarkdownBuilder.cs
@@ -60,11 +60,9 @@ private static Func<Type, bool> HasEventTags(IReadOnlyList<EventTag> requestedTa
                 throw new ArgumentNullException(nameof(requestedTags));
 
             return requestedTags.Count == 0
-                ? (Func<Type, bool>) AllowAllEvents
+                ? _ => true
                 : HasAnyRequestedEventTag;
 
-            static bool AllowAllEvents(Type eventType) => true;
-
             bool HasAnyRequestedEventTag(Type eventType)
             {
                 var eventTags = eventType

diff --git a/src/Be.Vlaanderen.Basisregisters.EventHandling/EventTag.cs b/src/Be.Vlaanderen.Basisregisters.EventHandling/EventTag.cs
@@ -2,9 +2,9 @@ namespace Be.Vlaanderen.Basisregisters.EventHandling
 {
     using System;
 
-    public class EventTag
+    public sealed class EventTag
     {
-        public class For
+        public static class For
         {
             public const string Sync = "sync";
             public const string Crab = "crab";
@@ -35,7 +35,7 @@ public static EventTag Create(string tagType)
         public override bool Equals(object? obj)
             => obj is EventTag tag && Equals(tag);
 
-        protected bool Equals(EventTag other)
+        private bool Equals(EventTag other)
             => _tagType == other._tagType;
 
         public override int GetHashCode()