Merge pull request #42 from Informatievlaanderen/SDTT-266-Cannot-read…

…-properties-of-null-reading-replace-at-removeCaret Add error message for empty localName
Informatievlaanderen · Feb 9, 2024 · 49192f4 · 49192f4
2 parents 9128d4f + 737bb3d
commit 49192f4
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/packages/oslo-converter-uml-ea/lib/converter-handlers/AttributeConverterHandler.ts b/packages/oslo-converter-uml-ea/lib/converter-handlers/AttributeConverterHandler.ts
@@ -84,6 +84,7 @@ export class AttributeConverterHandler extends ConverterHandler<EaAttribute> {
       const externalUri: string = getTagValue(attribute, TagNames.ExternalUri, null);
       if (externalUri) {
         uriRegistry.attributeIdUriMap.set(attribute.id, new URL(externalUri));
+        return;
       }
 
       let attributeBaseURI: string | undefined;
@@ -137,6 +138,10 @@ export class AttributeConverterHandler extends ConverterHandler<EaAttribute> {
         TagNames.LocalName,
         attribute.name,
       );
+
+      if(!localName){
+        throw new Error(`[AttributeConverterHandler]: Unable to determine local name for attribute (${attribute.path}). If you used a "name" tag, did you set it correctly?`)
+      }
       localName = toCamelCase(localName);
 
       const attributeURI: URL = new URL(`${attributeBaseURI}${localName}`);