Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry draft #319

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

poetry draft #319

wants to merge 3 commits into from

Conversation

goatrocks
Copy link
Contributor

Summary

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Jira story/task is put into PR title
  • Code has been self-reviewed
  • Hard-to-understand areas have been commented
  • Documentation has been updated
  • My changes generate no new warnings
  • Unit tests have been added for base functionality and known edge cases
  • Any dependent changes have been merged and published in downstream modules

@goatrocks goatrocks requested a review from mawelborn July 11, 2024 03:16
@goatrocks
Copy link
Contributor Author

goatrocks commented Jul 11, 2024 •
edited
Loading

thinking it would be good to combine this, #314, and #303 to switch to poetry, use optional dependencies, and get typing in for the next major client version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mawelborn mawelborn Awaiting requested review from mawelborn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@goatrocks