Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(*): Remove the need of hardcoded item heights in combo #14871

Open
wants to merge 19 commits into
base: 19.0.x
Choose a base branch
from
Open

refactor(*): Remove the need of hardcoded item heights in combo #14871

wants to merge 19 commits into from

Conversation

mddragnev
Copy link
Member

@mddragnev mddragnev commented Oct 3, 2024 •
edited
Loading

Closes #14285

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@mddragnev mddragnev marked this pull request as ready for review October 10, 2024 08:13
@mddragnev mddragnev changed the title refactor(*): Remove the need of hardcoded item heights refactor(*): Remove the need of hardcoded item heights in combo Oct 10, 2024
tishko0
tishko0 previously approved these changes Nov 1, 2024
View reviewed changes
@tishko0 tishko0 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 1, 2024
@ChronosSF ChronosSF changed the base branch from master to 19.0.x November 25, 2024 16:21
@ChronosSF ChronosSF dismissed tishko0’s stale review November 25, 2024 16:21

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tishko0 tishko0 tishko0 left review comments

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

@simeonoff simeonoff Awaiting requested review from simeonoff

At least 1 approving review is required to merge this pull request.

Assignees

@dkamburov dkamburov

@tishko0 tishko0

Labels
combo simple-combo version: 19.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the need for the common combo to hardcode ItemHeights
5 participants
@mddragnev @tishko0 @dkamburov @kdinev @simeonoff