Merge pull request #3277 from IgniteUI/SAndreeva/fix-bug-2792-7.0.x

fix(grid): mark grid for check inside NgZone when resizing #2792
IgniteUI · Dec 7, 2018 · f200ac9 · f200ac9
2 parents 41b4f50 + 70f9be3
commit f200ac9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/projects/igniteui-angular/src/lib/grids/grid-column-resizing.service.ts b/projects/igniteui-angular/src/lib/grids/grid-column-resizing.service.ts
@@ -1,4 +1,4 @@
-import { Injectable } from '@angular/core';
+import { Injectable, NgZone } from '@angular/core';
 import { isFirefox } from '../core/utils';
 import { IgxColumnComponent } from './column.component';
 
@@ -37,6 +37,8 @@ export class IgxColumnResizingService {
      */
     public column: IgxColumnComponent;
 
+    constructor(private zone: NgZone) { }
+
 
     /**
      * Returns the minimal possible width to which the column can be resized.
@@ -104,7 +106,8 @@ export class IgxColumnResizingService {
                 this.column.width = size;
             }
 
-            this.column.grid.markForCheck();
+            this.zone.run(() => {});
+
             this.column.grid.reflow();
             this.column.grid.onColumnResized.emit({
                 column: this.column,
@@ -145,7 +148,7 @@ export class IgxColumnResizingService {
                 this.column.width = (currentColWidth + diff) + 'px';
             }
 
-            this.column.grid.markForCheck();
+            this.zone.run(() => {});
             this.column.grid.reflow();
 
             if (currentColWidth !== parseFloat(this.column.width)) {

diff --git a/projects/igniteui-angular/src/lib/grids/grid-header.component.ts b/projects/igniteui-angular/src/lib/grids/grid-header.component.ts
@@ -27,7 +27,7 @@ import { IgxColumnResizingService } from './grid-column-resizing.service';
     selector: 'igx-grid-header',
     templateUrl: './grid-header.component.html'
 })
-export class IgxGridHeaderComponent implements OnInit, DoCheck {
+export class IgxGridHeaderComponent implements DoCheck {
 
     @Input()
     public column: IgxColumnComponent;
@@ -113,10 +113,6 @@ export class IgxGridHeaderComponent implements OnInit, DoCheck {
         public filteringService: IgxFilteringService
     ) { }
 
-    public ngOnInit() {
-        this.column.columnGroup ? this.zone.runTask(() => this.cdr.markForCheck()) :
-            this.cdr.markForCheck();
-    }
 
     public ngDoCheck() {
         this.getSortDirection();