[OpenXR] Remove DoF filtering #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
force-pushed
the
remove_dof_mapping
branch
2 times, most recently
from
5794cd8
to
4099cf2
Compare
We were filtering by DoF in order not to suggest some profiles for devices not supporting 6DoF controllers. On the one hand, this was only needed for HVR so we better handle it as an exception. And on the other hand, there is really no need to filter out profiles in general as the runtime will select the most appropiate one.
svillar
force-pushed
the
remove_dof_mapping
branch
from
4099cf2
to
03ff995
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were filtering by DoF in order not to suggest some profiles for devices not supporting 6DoF controllers. On the one hand, this was only needed for HVR so we better handle it as an exception. And on the other hand, there is really no need to filter out profiles in general as the runtime will select the most appropiate one.