Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move intent filters to VersionCheckActivity #1575

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

felipeerias
Copy link
Collaborator

VersionCheckActivity is the entry point of our application and the only Activity that we export, so it needs to use the intent filters that were previously associated to VRBrowserActivity.

These filters declare Wolvic as an application capable of viewing the Web URLs http:// and https:// as well as the special custom wolvic:// links.

VersionCheckActivity also needs to propagate the data received in the original Intent.

See also:

VersionCheckActivity is the entry point of our application and the
only Activity that we export, so it needs to use the intent filters
that were previously associated to VRBrowserActivity.

These filters declare Wolvic as an application capable of viewing
the Web URLs http:// and https:// as well as the special custom
wolvic:// links

https://developer.android.com/guide/components/intents-filters
https://developer.android.com/training/app-links/deep-linking
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Could you please also modify the project Wiki? We have a few command line examples on how to launch wolvic in kiosk mode and others that should be modified (yeah I should have done it when adding the activity but forgot about that)

@svillar svillar merged commit e2d7ade into main Oct 15, 2024
22 checks passed
@svillar svillar deleted the felipeerias/intentFilters branch October 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants