-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create New Tab page and add an option to set New Tab page as homepage #1574
base: main
Are you sure you want to change the base?
Conversation
@felipeerias @svillar (and other maintainers) This is a very draft initial implementation. Currently I just added a Homepage option that shows Bookmarks panel like this: https://drive.google.com/file/d/1feSPqru-LJJOmQ3kwPKKuEXal9dirkbr/view?usp=sharing I'm thinking of creating a specific New Tab page that shows bookmarks (and maybe other things too?). Do you have any ideas on how that New Tab page should look like? Is there any existing layout that I can use for this page? |
I think we should be consistent with what others do. See Desktop Firefox, Chrome, or Edge for inspiration |
64fb0d9
to
218b7b8
Compare
bf3f824
to
8ffd64b
Compare
01ac05b
to
96768a2
Compare
@felipeerias @svillar (and other maintainers) There's bug in the New Tab page that I'm not having any clues to debug. Basically, the hovering point is not exactly as it's showing. For example: The reverse is true too: when I actually hover in the item, the page doesn't recognize that and doesn't show the trash icon: Could you help me to debug this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is great work 🙂
In addition to these suggestions, we also need to add the New Page to the WindowViewModel
so other elements in the UI are updated correctly.
See WindowViewModel.setIsLibraryVisible()
and WindowViewModel.getIsLibraryVisible()
for reference.
app/src/common/shared/com/igalia/wolvic/ui/adapters/Bookmark.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/adapters/NewTabAdapter.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/views/library/BookmarksView.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/DisplayOptionsView.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/DisplayOptionsView.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/DisplayOptionsView.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/DisplayOptionsView.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/DisplayOptionsView.java
Outdated
Show resolved
Hide resolved
@felipeerias I have simplified the initial UI of the New Tab page like you suggested (the more complete UI is stored here as references for next PRs: https://github.com/haanhvu/wolvic/tree/issue1318-skeleton) I have also enabled going back to New Tab from another page or library panel. I'll wait for #1644 to be merged first to continue on it. Basically if #1644 works for library panel it would work for New Tab too |
fix #1318