Improve scrolling using eye tracking #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a couple of issues with the current gesture to scroll using eye tracking: 1. it allows users to scroll with both hands, initially it was only tied to the right hand 2. it prevents scrolling by moving the eyes. The scroll gesture should be done with the hand or the controller but not with the gaze. The current code scrolls if user moves their eyes up and down while pinching/clicking and holding. To fix that we pass a new parameter to the Update() method in the input source carrying the transform for the eye gaze. That transform would be used to set the starting point of the scroll action if there is a scroll or the pointer position otherwise. Methods like Update(), EmulateControllerFromHands() or HandleEyeTrackingScroll() are suffering from bad design decisions and this PR does not improve the situation. In any case that's a different topic and should be addressed in a separate PR. Tested in: * Pico 4E (5.11.1) * Meta Quest Pro (v71) * Magic Leap 2
javifernandez
requested changes
Oct 11, 2024
felipeerias
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Improve scrolling using eye tracking This PR fixes a couple of issues with the current gesture to scroll using eye tracking: 1. it allows users to scroll with both hands, initially it was only tied to the right hand 2. it prevents scrolling by moving the eyes. The scroll gesture should be done with the hand or the controller but not with the gaze. The current code scrolls if user moves their eyes up and down while pinching/clicking and holding. To fix that we pass a new parameter to the Update() method in the input source carrying the transform for the eye gaze. That transform would be used to set the starting point of the scroll action if there is a scroll or the pointer position otherwise. Methods like Update(), EmulateControllerFromHands() or HandleEyeTrackingScroll() are suffering from bad design decisions and this PR does not improve the situation. In any case that's a different topic and should be addressed in a separate PR. Tested in: * Pico 4E (5.11.1) * Meta Quest Pro (v71) * Magic Leap 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues with the current gesture to scroll using eye tracking:
To fix that we pass a new parameter to the Update() method in the input source carrying the transform for the eye gaze. That transform would be used to set the starting point of the scroll action if there is a scroll or the pointer position otherwise.
Methods like Update(), EmulateControllerFromHands() or HandleEyeTrackingScroll() are suffering from bad design decisions and this PR does not improve the situation. In any case that's a different topic and should be addressed in a separate PR.
Tested in:
Fixes #1571, fixes #1572