Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP Error 400 in consent.youtube.com #1563

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix HTTP Error 400 in consent.youtube.com #1563

merged 1 commit into from
Oct 7, 2024

Conversation

svillar
Copy link
Member

@svillar svillar commented Oct 7, 2024

Our YouTube internal extension appends "app=desktop" param to the YouTube URLs in order to get immersive videos. That unfortunatelly breaks the new consent page making the request invalid. The server returns a HTTP 400 code.

The solution is not to add that param for those URLs.

Our YouTube internal extension appends "app=desktop" param to the
YouTube URLs in order to get immersive videos. That unfortunatelly
breaks the new consent page making the request invalid. The server
returns a HTTP 400 code.

The solution is not to add that param for those URLs.
Copy link
Member

@javifernandez javifernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and fix the issue.

Copy link
Member

@javifernandez javifernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svillar svillar merged commit 0a1033e into main Oct 7, 2024
22 checks passed
@svillar svillar deleted the youtube_consent branch October 7, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants