Add updated_at field to task #590
Conversation
There was a problem hiding this comment.
There is another function in the DAO that modifies the tasks data, PostgreSQLTaskDAO::update(), but I'm not sure when/if we use it. We should either:
- Set the
updated_atfield in that function too. - Verify whether it's actually unused and delete it!
I've been reviewing the usage of every DAO function while working on #513 to prevent rewriting unused code, so you may do only 1 this time and we leave 2 for later if you are in a hurry.
anarute
force-pushed
the
add-updated-at-to-task
branch
from
2f7834d
to
36f9690
Compare
| * IMPORTANT: they must be ordered for their proper execution. | ||
| */ | ||
| $sqlFiles = array(); | ||
| $sqlFiles[] = SQLPATH . "add-updated-at-to-task.sql"; |
There was a problem hiding this comment.
I missed this before: I think we should also include bump-db-version-2-22.sql here. I wasn't planning to do any new "stable" releases so every change in the DB should bump its version so we can easily track where the DB is with regard to the code.
There was a problem hiding this comment.
I think it's all good, could you do just this small modification?
I couldn't find anywhere this method was being used so I removed it. I'm trying to port the task DAO to use PDO, but it's been a bit tricky 😬 |
You may want to try to migrate a small DAO first to "practice", we still have some! |
It will be used mainly to track when users update their vacation plans
Whenever a task is created or updated, save the current moment in the updated_at column.
anarute
force-pushed
the
add-updated-at-to-task
branch
from
4dd316e
to
fa1d090
Compare
We need to know when users update their tasks, specially the ones related to their vacation plans.
This patch adds a column called
updated_atto the task table as well as their migration scripts.It also starts populating the field whenever a task is created or updated.