Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav updates for #34, and bring code changes from staging into this repo #39

Merged
merged 14 commits into from
Feb 21, 2020

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Feb 18, 2020

Changes

This pull request makes the following changes:

Why

For #34

Also because there were code changes made on prod/staging that were not reflected here.

Screen Shot 2020-02-18 at 23 26 59

Testing/Questions

Features that this PR affects:

  • Header on all pages
  • The main and secondary navs as inserted into a SiteOrigin page builder

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Is something wrong with the sticky nav?

Steps to test this PR:

  1. In Settings > Reading, set the homepage to the "NEW HOMEPAGE TESTING" page
  2. Edit the "NEW HOMEPAGE TESTING" page in the SiteOrigin page builder. In the Topper section, in the second Layout Builder element, edit that Layout Builder:
    • remove the text widgets containing the mocked-up html menus
    • add an Enhanced Text widget with the following content:
<?php
    get_template_part( 'partials/nav', 'main' );
    get_template_part( 'partials/nav', 'secondary' );
?>
  1. view the homepage.

@benlk benlk added this to the Homepage update quicksign milestone Feb 18, 2020
@benlk benlk self-assigned this Feb 18, 2020
@benlk benlk changed the base branch from master to staging February 18, 2020 15:36
@benlk benlk changed the title 34 nav updates and copy from staging Nav updates for #34, and bring code changes from staging into this repo Feb 18, 2020
@benlk benlk marked this pull request as ready for review February 19, 2020 04:32
@benlk benlk requested a review from joshdarby February 19, 2020 04:32
@benlk
Copy link
Collaborator Author

benlk commented Feb 19, 2020

This is now ready for review.

@benlk
Copy link
Collaborator Author

benlk commented Feb 19, 2020

Notes from review:

  • figure out why the sticky nav is showing up
  • blank space is caused by this markup, which must be hidden via CSS:
    Screen Shot 2020-02-19 at 12 36 22
  • the different layout at different screen sizes is in fact a different layout within the Pagebuilder, which will also need to be updated, or if we can get the Pagebuilder to hide the entire layout below a certain screen size — but I think Sonya should make those changes on the staging site, and copy them to prod
    Screen Shot 2020-02-19 at 12 39 08
  • How will we copy these changes from Staging to Prod? Needs a bit of research; deploying this PR for review will provide a good time to do that testing.

@benlk
Copy link
Collaborator Author

benlk commented Feb 20, 2020

In the SiteOrigin page builder:

  • For the Enhanced Text widget, disable automatic addition of paragraphs
  • For the row containing the Enhanced Text widget, click the wrench icon, then under Layout set "Cell Vertical Alignment" to "Top"

That plus the CSS in a7e3b5e get us to this:

Screen Shot 2020-02-20 at 16 21 27

@benlk
Copy link
Collaborator Author

benlk commented Feb 20, 2020

Regarding exports: https://siteorigin.com/page-builder/exporting-content/

SiteOrigin PageBuilder does not appear to have a way to export a single post. Our options for transferring from staging to prod are:

  1. Recreate changes by hand
  2. Transfer the post_content of this page via DB edits, which is both risky and not guaranteed to work.

@benlk
Copy link
Collaborator Author

benlk commented Feb 20, 2020

Still to address:

  • why is the sticky nav showing up?

@benlk benlk merged commit 7c03c28 into staging Feb 21, 2020
@benlk benlk deleted the 34-nav-updates-and-copy-from-staging branch February 21, 2020 19:19
@benlk benlk mentioned this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant