-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom ltw templates #154
Custom ltw templates #154
Conversation
Did you know that the Gutenberg editor, in the background, renders shortcodes displayed in the editor? diff --git a/wp-content/themes/currentorg/partials/projects-single-held.php b/wp-content/themes/currentorg/partials/projects-single-held.php
index a3ba61a..26bf5cd 100644
--- a/wp-content/themes/currentorg/partials/projects-single-held.php
+++ b/wp-content/themes/currentorg/partials/projects-single-held.php
@@ -71,7 +71,7 @@ if( ! empty ( $custom['project-video'][0] ) ) {
esc_attr( $term->slug ),
// @todo: make this be a link that triggers the search filter for this term
get_term_link( $term ),
- esc_html( $term->name ),
+ esc_html( $term->name )
);
if( $terms_index != $terms_count ){
echo '<span class="delimiter">' . $delimiter . '</span>';
@@ -133,7 +133,7 @@ if( ! empty ( $custom['project-video'][0] ) ) {
if ( ! empty( $custom['project-contact-name'][0] ) || ! empty( $custom['project-contact-email'] ) ) {
printf(
'<label class="project-single-contact">%1$s: </label>',
- __( 'Contact', 'current-ltw-projects' ),
+ __( 'Contact', 'current-ltw-projects' )
);
}
@@ -182,4 +182,4 @@ if( ! empty ( $custom['project-video'][0] ) ) {
?>
</div>
-</article>
\ No newline at end of file
+</article> fixes this error. |
Upgrading to PHP 7.3 fixes it as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that doesn't concern this PR but which we'll want to remove eventually:
umbrella-currentorg/wp-content/plugins/current-ltw-projects/post-types/projects.php
Lines 568 to 573 in 44bce79
add_action('largo_before_post_header', function() { | |
printf( | |
'<pre>%1$s</pre>', | |
esc_html( var_export( get_post_custom( get_the_ID() ), true) ) | |
); | |
}); |
It's debug code, and it's appearing on posts. http://staging.current.flywheelsites.com/2020/05/reflections-from-observing-good-radio-bosses/
Changes
This pull request makes the following changes:
template-page-ltw.php
to use for LTW pages that includes no header or navigation and only a reduced logoarchive-projects.php
archive template to match the look of the new template abovecurrent-ltw-template-stylesheet
script and enqueues it where necessaryShortcode page:
Archive:
Form page:
Why
For #153
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
archive-projects.php
just include this new template, but then we'd need to make a ton of conditionals inside of it to distinguish between archive vs. page, and also I wasn't sure if they're ever going to want them to look different. Does it make sense to keep them separate but equal for now?Steps to test this PR: