137 filtering hs

[benlk]

Changes

This pull request implements the following portion of #137 (comment):

• submit the form when the <select> changes
• track whether the inputs in the details element are changed, and how many are checked
• when the
  element is closed or otherwise onBlur, if the inputs there are changed, submit the search
• limit the number of checked inputs to no more than 3: if it's 3, disable all inputs until one is unchecked

It also:

• makes the summary in the details full width when the details is open

Why

For #137

Testing/Questions

Features that this PR affects:

• search form

Questions that need to be answered before merging:

• Is this PR targeting the correct branch in this repository?
• [ ]

Steps to test this PR:

1. check that the form submits when the select's value changes
2. Check that the form submits when the <details> closes, only if the checkboxes checked have changed.
   • uncheck and check the same box: should not submit
   • check a new box: should submit
   • uncheck a checked box: should submit
3. check that if three checkboxes are checked, other checkboxes in that dropdown are disabled:
   • on page load, with three checked
   • after checking three

[benlk]

This is now :deployed: to staging and ready for review.

[benlk]

• remove automatic submit from search JS
• add second search button to a box containing the org type and categories
• move that org type/categories/search cluster to the right on desktop. On mobile, two search buttons, with the rows stacked.
• figure out what's causing timeouts

[joshdarby]

figure out what's causing timeouts

I think the problem here happens when there are no posts found for the specific query.

For example:
http://staging.current.flywheelsites.com/local-projects/?projects-search=&tax_input%5Bproject-org-type%5D%5B%5D=&tax_input%5Bproject-category%5D%5B%5D=6996&tax_input%5Bproject-category%5D%5B%5D=6997 works and there are 36 results found.

The issue is happening when 0 results are found and the projects-single-held.php file is trying to be loaded because it assumes that $query->the_post is not empty.

Putting the include() function for the holder file here inside of a if ( $query->have_posts() ) conditional fixes the issue.

umbrella-currentorg/wp-content/themes/currentorg/partials/projects-base.php

Line 70 in c7f89c0

include( locate_template( 'partials/projects-single-holder.php', false, false ) );

[joshdarby]

Solution for the above committed in 0ce254f

[benlk]

Desktop:

Narrow desktop:

Phone:

[joshdarby]

@benlk can we merge/close this since it's already on staging?