-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
122/137: Filtering of project search #138
Conversation
…ct terms in term list and make them rectangular, add submit button to search
Probably. If we didn't, we'd need to update the posts that display on the archive page and make sure they link to the local projects page with a param to the specific project instead of the actual project post page
I think that's fine unless we think people will be manually typing in the URL for specific categories? |
Other than the few things above, this functions as expected! |
The links should work now. With thanks to https://www.filamentgroup.com/lab/select-css.html and an inline'd PNG, we have much better-looking dropdowns now. |
@benlk The new changes look great! One last question: If a user clicks on a category inside of a project in the projects list and gets taken to a page that is now querying that category, should we update the dropdown to display that category as checked? |
wp-content/themes/currentorg/partials/content-projects-list-item.php
Outdated
Show resolved
Hide resolved
…other project taxonomies, for simpler generation of tag links.
It should have; it wasn't. This identified a bug: the param used for these links was incorrect. Since #138 (comment):
|
Changes
This pull request makes the following changes:
Why
For #137
Testing/Questions
Features that this PR affects:
/local-that-works/
and on any page with the project shortcodeQuestions that need to be answered before merging:
Steps to test this PR: