Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest updates multilingual #157

Merged
merged 5 commits into from
May 2, 2024

Conversation

lickem22
Copy link
Contributor

Reviewer: @amiraliemami
Estimate: 30mins


Ticket

Fixes:

Description

Goal

The goal of this PR is to add the latest changes blogpost for multilingual support

Changes

The blogpost has been added as well as some supporting images.

How has this been tested?

To-do before merge

Merge this PR

Checklist

Fill with x for completed. Delete any lines that are not relevant

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts
  • I have updated the automated tests (if applicable)
  • I have updated the requirements (if applicable)
  • I have updated the README file (if applicable)
  • I have updated affected documentation (if applicable)

Comment on lines +21 to +24
| Main page |
| ![old UI main screenshot](../images/mui_switch/mui_main.png) | ![Multilingual main screenshot](../images/multilingual/mult_main.png) |
| Edit page |
| ![old UI edit screenshot](../images/mui_switch/mui_edit.png) | ![Multilingual edit screenshot](../images/multilingual/mult_edit.png) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you upload higher resolution screenshots here? It shows up as small on the blogpost because it's too low res I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Let me check how I can do that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you fullscreen the webpage and take a screenshot that should be good enough

@amiraliemami
Copy link
Collaborator

Can you change the target for this PR to be the multilingual feature branch instead of main?

@amiraliemami amiraliemami self-requested a review April 18, 2024 12:39
Copy link
Collaborator

@amiraliemami amiraliemami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Left some comments - pls merge to the feature branch instead of main once done. Thanks!!

@lickem22 lickem22 changed the base branch from main to feature-multilingual May 2, 2024 08:25
lickem22 and others added 2 commits May 2, 2024 11:25
Co-authored-by: Amir Emami <41763233+amiraliemami@users.noreply.github.com>
Co-authored-by: Amir Emami <41763233+amiraliemami@users.noreply.github.com>
@lickem22 lickem22 merged commit 4e9dfa2 into feature-multilingual May 2, 2024
1 check passed
@lickem22 lickem22 deleted the latest-updates-multilingual branch May 2, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants