Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA - GitHub Actions CI #9

Merged
merged 5 commits into from
Sep 18, 2024
Merged

INFRA - GitHub Actions CI #9

merged 5 commits into from
Sep 18, 2024

Conversation

davidbeechey
Copy link
Collaborator

@davidbeechey davidbeechey commented Aug 20, 2024

Add basic "Cargo Build & Test" and "Linter" workflows.

Linter:

  • Runs clippy
  • Checks for TODOs
  • Enforces LF

(Currently fails because we have no Rust to build...)

To Do:

  • Spell check

@kshxtij
Copy link
Contributor

kshxtij commented Aug 21, 2024

LGTM, some other random rust CI tools i've run into which you could consider are:

  1. https://crates.io/crates/typos
  2. https://crates.io/crates/cargo-audit
  3. https://rust-lang.github.io/rustfmt/ to enforce code style (the rust lsp respects a root rustfmt.toml as well and this can enforce line endings)

There's also yamlfmt if we forsee ourself using lots of yaml configs but otherwise it's probably not needed.

Copy link

@TomLonergan03 TomLonergan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidbeechey davidbeechey merged commit 58b6f19 into main Sep 18, 2024
8 checks passed
@davidbeechey davidbeechey deleted the infra-github_ci branch September 18, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants