This repository has been archived by the owner on Jul 30, 2022. It is now read-only.
1.39 #116
Open
1.39 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isLogged in was deprecated in 1.36 and removed recently. See T270450 for more information This makes Pivot skin work again. Fixes: Hutchy68#114
In 1.36 the skin registration process was modified to support registration for common skin meta data This removes warnings in >= 1.39.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings in 1.39. There is no urgency with this one. #115 is more urgent given the skin is using incompatible code.
PR Submission:
Additional Information Below
Wikimedia\suppressWarnings();you'll see various warnings about future breakages. This changes takes care of all of these.No urgency to merge this one. Those warnings won't likely become a problem until at least MediaWiki 1.41.