HTMLFormControlsCollection: implement namedItem()

src/main/java/org/htmlunit/javascript/host/html/HTMLFormControlsCollection.java

@@ -14,18 +14,51 @@
  */
 package org.htmlunit.javascript.host.html;
 
+import org.htmlunit.html.DomElement;
+import org.htmlunit.html.DomNode;
 import org.htmlunit.javascript.configuration.JsxClass;
 import org.htmlunit.javascript.configuration.JsxConstructor;
+import org.htmlunit.javascript.configuration.JsxFunction;
+import org.htmlunit.javascript.host.dom.RadioNodeList;
+
+import java.util.ArrayList;
+import java.util.List;
 
 /**
  * A JavaScript object for {@code HTMLFormControlsCollection}.
  *
  * @author Ahmed Ashour
  * @author Ronald Brill
+ * @author Lai Quang Duong
  */
 @JsxClass
 public class HTMLFormControlsCollection extends HTMLCollection {
 
+    /**
+     * Creates an instance.
+     */
+    public HTMLFormControlsCollection() {
+    }
+
+    /**
+     * Creates an instance.
+     * @param domNode parent scope
+     * @param attributeChangeSensitive indicates if the content of the collection may change when an attribute
+     * of a descendant node of parentScope changes (attribute added, modified or removed)
+     */
+    public HTMLFormControlsCollection(final DomNode domNode, final boolean attributeChangeSensitive) {
+        super(domNode, attributeChangeSensitive);
+    }
+
+    /**
+     * Constructs an instance with an initial cache value.
+     * @param domNode the parent scope, on which we listen for changes
+     * @param initialElements the initial content for the cache
+     */
+    HTMLFormControlsCollection(final DomNode domNode, final List<DomNode> initialElements) {
+        super(domNode, initialElements);
+    }
+
     /**
      * JavaScript constructor.
      */
@@ -34,4 +67,47 @@ public class HTMLFormControlsCollection extends HTMLCollection {
     public void jsConstructor() {
         super.jsConstructor();
     }
+
+    /**
+     * Returns the element with ID or name match the specified value from the collection.
+     * If there are multiple matching elements, then a RadioNodeList object containing all those elements is returned.
+     * @param name the name or id the element or elements to return
+     * @return the element or elements corresponding to the specified name or id
+     * @see <a href="https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#the-htmlformcontrolscollection-interface">HTML Standard</a>
+     */
+    @Override
+    @JsxFunction
+    public Object namedItem(final String name) {
+        if (name.isEmpty()) {
+            return null;
+        }
+
+        final List<DomNode> elements = new ArrayList<>();
+        for (final Object next : getElements()) {
+            if (next instanceof DomElement) {
+                final DomElement elem = (DomElement) next;
+                final String nodeName = elem.getAttributeDirect(DomElement.NAME_ATTRIBUTE);
+                if (name.equals(nodeName)) {
+                    elements.add(elem);
+                    continue;
+                }
+
+                final String id = elem.getId();
+                if (name.equals(id)) {
+                    elements.add(elem);
+                }
+            }
+        }
+
+        if (elements.isEmpty()) {
+            return null;
+        }
+        if (elements.size() == 1) {
+            return getScriptableForElement(elements.get(0));
+        }
+
+        final RadioNodeList nodeList = new RadioNodeList(getDomNodeOrDie(), elements);
+        nodeList.setElementsSupplier(getElementSupplier());
+        return nodeList;
+    }
 }

src/main/java/org/htmlunit/javascript/host/html/HTMLFormElement.java

@@ -90,10 +90,11 @@ public void setName(final String name) {
      * @return the value of this property
      */
     @JsxGetter
-    public HTMLCollection getElements() {
+    public HTMLFormControlsCollection getElements() {
         final HtmlForm htmlForm = getHtmlForm();
 
-        final HTMLCollection elements = new HTMLCollection(htmlForm, false) {
+        final HTMLFormControlsCollection elements =new HTMLFormControlsCollection(htmlForm,
+                false) {
             @Override
             protected Object getWithPreemption(final String name) {
                 return HTMLFormElement.this.getWithPreemption(name);

src/test/java/org/htmlunit/javascript/host/html/HTMLFormControlsCollectionTest.java

@@ -32,7 +32,7 @@ public class HTMLFormControlsCollectionTest extends WebDriverTestCase {
      * @throws Exception on test failure
      */
     @Test
-    @Alerts({"false", "false", "0", "true", "1", "null"}) //FIXME: should be "true", "true", "2", "true", "1", "null"
+    @Alerts({"true", "true", "2", "true", "1", "null"})
     public void namedItem() throws Exception {
         final String html = "<html><head>\n"
                 + "<script>\n"