fix some warnings

HtmlUnit · Apr 20, 2024 · 47713ff · 47713ff
1 parent 71a3142
commit 47713ff
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 23 deletions.
diff --git a/src/test/java/org/htmlunit/cyberneko/HTMLScannerTest.java b/src/test/java/org/htmlunit/cyberneko/HTMLScannerTest.java
@@ -20,7 +20,6 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.io.IOException;
-import java.io.PrintWriter;
 import java.io.StringReader;
 import java.io.StringWriter;
 import java.util.ArrayList;

diff --git a/src/test/java/org/htmlunit/cyberneko/util/FastHashMapTest.java b/src/test/java/org/htmlunit/cyberneko/util/FastHashMapTest.java
@@ -292,19 +292,21 @@ public void serializable() throws IOException, ClassNotFoundException {
         final FastHashMap<String, Integer> src = new FastHashMap<>();
 
         final ByteArrayOutputStream buffer = new ByteArrayOutputStream();
-        final ObjectOutputStream objectOutputStream = new ObjectOutputStream(buffer);
-        objectOutputStream.writeObject(src);
-        objectOutputStream.close();
+        try (ObjectOutputStream objectOutputStream = new ObjectOutputStream(buffer)) {
+            objectOutputStream.writeObject(src);
+            objectOutputStream.close();
+        }
+
+        try (ObjectInputStream objectInputStream = new ObjectInputStream(new ByteArrayInputStream(buffer.toByteArray()))) {
+            final FastHashMap<String, Integer> copy = (FastHashMap<String, Integer>) objectInputStream.readObject();
 
-        final ObjectInputStream objectInputStream = new ObjectInputStream(new ByteArrayInputStream(buffer.toByteArray()));
-        final FastHashMap<String, Integer> copy = (FastHashMap<String, Integer>) objectInputStream.readObject();
-        objectInputStream.close();
+            assertEquals(src.size(), copy.size());
 
-        assertEquals(src.size(), copy.size());
+            // clone still works
+            copy.put("test", 1);
+            assertEquals(1, copy.get("test"));
+        }
 
-        // clone still works
-        copy.put("test", 1);
-        assertEquals(1, copy.get("test"));
     }
 
     /**
@@ -324,18 +326,19 @@ public void serializable_notEmpty() throws IOException, ClassNotFoundException {
         src.remove("b");
 
         final ByteArrayOutputStream buffer = new ByteArrayOutputStream();
-        final ObjectOutputStream objectOutputStream = new ObjectOutputStream(buffer);
-        objectOutputStream.writeObject(src);
-        objectOutputStream.close();
-
-        final ObjectInputStream objectInputStream = new ObjectInputStream(new ByteArrayInputStream(buffer.toByteArray()));
-        final FastHashMap<String, Integer> copy = (FastHashMap<String, Integer>) objectInputStream.readObject();
-        objectInputStream.close();
-
-        assertEquals(src.size(), copy.size());
-        assertEquals(1, copy.get("a"));
-        assertEquals(3, copy.get("c"));
-        assertEquals(4, copy.get("d"));
+        try (ObjectOutputStream objectOutputStream = new ObjectOutputStream(buffer)) {
+            objectOutputStream.writeObject(src);
+            objectOutputStream.close();
+        }
+        try (ObjectInputStream objectInputStream = new ObjectInputStream(new ByteArrayInputStream(buffer.toByteArray()))) {
+            final FastHashMap<String, Integer> copy = (FastHashMap<String, Integer>) objectInputStream.readObject();
+            objectInputStream.close();
+
+            assertEquals(src.size(), copy.size());
+            assertEquals(1, copy.get("a"));
+            assertEquals(3, copy.get("c"));
+            assertEquals(4, copy.get("d"));
+        }
     }
 
     /**