Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math magicians: full website #7

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Math magicians: full website #7

merged 7 commits into from
Aug 30, 2023

Conversation

HossainAraf
Copy link
Owner

@HossainAraf HossainAraf commented Aug 30, 2023

Methods implemented:

  • Create a website consisting of 3 pages: Home, Calculator, and Quote;
  • The general layout should match the provided wireframes;
  • Use React basic styling (inline styles, importing CSS and pre-processed CSS files);
  • Navigation links for all 3 routes are displayed on each page.

Copy link

@ichala ichala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Student ,

Status: Approved ✔️ ✔️ ✔️

68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f6c3366516333614356304871707a5763552f67697068792e676966

To Highlight 💪🏻

  • The website consisting of 3 pages: Home, Calculator, and Quote ✔️
  • The general layout match the given wireframes✔️
  • For every page, there are a dedicated route to it made possible by React Router V6.✔️
  • Navigation links for all three routes are displayed on each page✔️

Good job implementing the requirements 👍 Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Optional Suggestions :

  • N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag ichala in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@HossainAraf HossainAraf merged commit 21fac8e into dev Aug 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants