-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lune 0.8.4 #171516
lune 0.8.4 #171516
Conversation
88a9da3
to
b025ab9
Compare
lune: update build Signed-off-by: Rui Chen <rui@chenrui.dev>
b025ab9
to
1c9b5f2
Compare
@@ -15,10 +15,11 @@ class Lune < Formula | |||
sha256 cellar: :any_skip_relocation, x86_64_linux: "53e9d5eadb78c68c2fd20d7184609e1a560f8efe3ed6e8b2f144194e8cf3fe9b" | |||
end | |||
|
|||
depends_on "cmake" => :build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need CMake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cmake is a dependency within its rust crates: https://github.com/lune-org/lune/blob/7e784ba361ba568f76aa17d0d544d170db86dfc0/Cargo.lock#L502
I just checked what happens if it's omitted, and it does throw this error:
failed to execute command: No such file or directory (os error 2)
is `cmake` not installed?
build script failed, must exit now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I'm more interested in what it's building and whether it's duplicating a formula we already have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error: failed to run custom build command for `libz-ng-sys v1.1.15`
Caused by:
process didn't exit successfully: `/private/tmp/lune-20240512-89103-nq6fiz/lune-0.8.4/target/release/build/libz-ng-sys-f6ac78e7be068455/build-script-build_zng` (exit status: 101)
--- stdout
CMAKE_TOOLCHAIN_FILE_aarch64-apple-darwin = None
CMAKE_TOOLCHAIN_FILE_aarch64_apple_darwin = None
HOST_CMAKE_TOOLCHAIN_FILE = None
CMAKE_TOOLCHAIN_FILE = None
CMAKE_GENERATOR_aarch64-apple-darwin = None
CMAKE_GENERATOR_aarch64_apple_darwin = None
HOST_CMAKE_GENERATOR = None
CMAKE_GENERATOR = None
CMAKE_PREFIX_PATH_aarch64-apple-darwin = None
CMAKE_PREFIX_PATH_aarch64_apple_darwin = None
HOST_CMAKE_PREFIX_PATH = None
CMAKE_PREFIX_PATH = Some("/opt/homebrew")
CMAKE_aarch64-apple-darwin = None
CMAKE_aarch64_apple_darwin = None
HOST_CMAKE = None
CMAKE = None
running: cd "/private/tmp/lune-20240512-89103-nq6fiz/lune-0.8.4/target/release/build/libz-ng-sys-0387c71c4fe444c1/out/build" && CMAKE_PREFIX_PATH="/opt/homebrew" "cmake" "/Users/rui/Library/Caches/Homebrew/cargo_cache/registry/src/index.crates.io-6f17d22bba15001f/libz-ng-sys-1.1.15/src/zlib-ng" "-DCMAKE_OSX_ARCHITECTURES=arm64" "-DBUILD_SHARED_LIBS=OFF" "-DZLIB_COMPAT=OFF" "-DZLIB_ENABLE_TESTS=OFF" "-DWITH_GZFILEOP=ON" "-DCMAKE_INSTALL_PREFIX=/private/tmp/lune-20240512-89103-nq6fiz/lune-0.8.4/target/release/build/libz-ng-sys-0387c71c4fe444c1/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC --target=arm64-apple-darwin -mmacosx-version-min=14.4" "-DCMAKE_C_COMPILER=/opt/homebrew/Library/Homebrew/shims/mac/super/clang" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC --target=arm64-apple-darwin -mmacosx-version-min=14.4" "-DCMAKE_CXX_COMPILER=/opt/homebrew/Library/Homebrew/shims/mac/super/clang++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC --target=arm64-apple-darwin -mmacosx-version-min=14.4" "-DCMAKE_ASM_COMPILER=/opt/homebrew/Library/Homebrew/shims/mac/super/clang" "-DCMAKE_BUILD_TYPE=MinSizeRel"
--- stderr
thread 'main' panicked at /Users/rui/Library/Caches/Homebrew/cargo_cache/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:1098:5:
failed to execute command: No such file or directory (os error 2)
is `cmake` not installed?
build script failed, must exit now
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same deal as:
🤖 An automated task has requested bottles to be published to this PR. |
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
Added a builtin API for regular expressions.
Example basic usage:
Check out the documentation for more details.
Added support for buffers as arguments in builtin APIs (#148)
This includes APIs such as
fs.writeFile
,serde.encode
, and more.Added support for cross-compilation of standalone binaries (#162)
You can now compile standalone binaries for other platforms by passing
an additional
target
argument to thebuild
subcommand:Currently supported targets are the same as the ones included with each
release of Lune on GitHub. Check releases for a full list of targets.
Added
stdio.readToEnd()
for reading the entire stdin passed to LuneChanged
Split the repository into modular crates instead of a monolith. (#188)
If you previously depended on Lune as a crate, nothing about it has changed for version
0.8.4
, but now each individual sub-crate has also been published and is available for use:lune
(old)lune-utils
lune-roblox
lune-std-*
for every builtin libraryWhen depending on the main
lune
crate, each builtin library also has a feature flag that can be toggled in the formatstd-*
.In general, this should mean that it is now much easier to make your own Lune builtin, publish your own flavor of a Lune CLI, or take advantage of all the work that has been done for Lune as a runtime when making your own Rust programs.
Changed the
User-Agent
header innet.request
to be more descriptive (#186)Updated to Luau version
0.622
.Fixed
lz4
format in high compression modenet.serve
no longer accepting ipv6 addressesnet.serve
being raw bytes instead of strings