-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H5178 and multi-sensor device support #42
base: master
Are you sure you want to change the base?
H5178 and multi-sensor device support #42
Conversation
I didn't actually intend on creating a pull request quite yet, I'd like to let this sit for a couple days to confirm it doesn't blow up. |
@noah-holland Thank you for the PR. I think I found what a H5178 is. Including this PR looks like it would alter the data storage name and effectively erase all historical data for existing devices. Because of this, I am hesitant to pull it in at the moment but understand the change. I am planning on rewriting this component which will require breaking changes; I will keep this device in mind when trying to create the data model and, if it is ok, will likely ask you to help test it when it gets to that stage |
Sounds good, I'll go ahead and close this PR then! |
If it is ok with you, I would prefer to keep this open just so I do not forget about it. If not, feel free to close it again. |
@noah-holland do you have a ble advertisement for this sensor. We are merging this integration into ble monitor and I would like to see the format of the ble advertisement from a hcidump to add it. |
@noah-holland I've included the sensor in BLE monitor (4.2.1-beta). |
This adds support for devices with "more than one sensor", like the H5178 which has an outdoor module that reports to the base unit.
It also adds specific decoding support for the H5178. The unit acts similarly to H5101/H5102, but has a byte preceding the temperature/humidity payload that seems to differentiate which sensor module the data is for (in this case 00 for the base unit, 01 for the outdoor module).