Update/clean up #49

JettTech · 2024-07-08T08:25:02Z

Note: This handles issue #48.

Context: This handles the issue @zo-el pointed out last Friday as well as few other bugs that were hard to find in the previous structure. It also cleans up the code base to support maintainability and knowledge sharing, with attn to supporting the ongoing sl rotation work.

Updates:

removes redundant types
groups code into related folders
changes admin call from list_running_app to list_apps(Some(AppStatusFilter::Enabled))
updates naming to be more explicit
cleans up helper fn and flow
fixes id ref bugs
fixes issue Not updating HHA when happ is disabled #48 (listed above)
removes the functionality to save the host's default happ pricing preferences to a file under {SL_PREFS_PATH}

src/lib.rs

src/types/hbs.rs

zo-el · 2024-07-10T03:00:44Z

src/types/happ.rs

+    pub fn save(self) -> Result<Self> {
+        if let Ok(path) = env::var("SL_PREFS_PATH") {
+            trace!("Writing default servicelogger prefs to {}", &path);
+            // create or overwrite to a file
+            let file = File::create(&path)?;
+            serde_yaml::to_writer(file, &self).context(format!(
+                "Failed writing service logger preferences to file {}",
+                path
+            ))?;
+        };
+        Ok(self)
+    }


Is this still in use? If this is a clean up this should be removed

It is in use upon install of the hosted happs, in order to save the hard coded happ preferences to a file. To confirm, you're saying we no longer need to create and reference this preference file, correct?

After your implementation of getting the preferences from HHA for SL, I don't think we have been using this file.
The only place would be the hpos-api, and if that's the case that needs to be updated since that will no longer be accurate

OK. It does look like it's being used there. I'll make a PR to amend that out too.

src/types/hbs.rs

zo-el · 2024-07-10T03:09:28Z

src/utils/core_app.rs

+use hpos_hc_connect::hha_types::HappAndHost;
+use tracing::trace;
+
+pub async fn get_host_preferences(core_app_client: &mut HHAAgent) -> Result<HappPreferences> {


Suggestion: All these zomeCalls could be added to the HHAAgent impl here: https://github.com/Holo-Host/hpos-service-crates/blob/main/crates/hpos_connect_hc/src/hha_agent.rs#L56-L89

Done. Can you take a look and approve at the dependent pr: Holo-Host/hpos-service-crates#191

Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com>

…aller into update/clean-up

* jurisdictions and categories struct compat with HHA * linting * don't panic if none * lint * hpos_hc_connect: bump to latest * update flake.nix * holochain v0.4.0-dev.1 (#47) * get_happ_preferences: update payload * clippy * edit names * clean up & restructure * move hbs types * import download_file from hpos_hc_connect * inline doc touch-ups * clean up comments * merge clean-up * Update/clean up (#49) * edit names * clean up & restructure * move hbs types * import download_file from hpos_hc_connect * inline doc touch-ups * clean up comments * Update src/types/hbs.rs Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com> * import core app types from hpos_hc_connect * remove option from kyc * edit comments --------- Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com> --------- Co-authored-by: Alastair Ong <alastair.ong@holo.host> Co-authored-by: peeech <pj@imagine-nyc.com> Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com>

### Updates: - Adds the zome calls in response to the suggestion from the [holo-auto-installer pr #49](Holo-Host/holo-auto-installer#49)

* feat: added invoice due date from note * feat: imports clean up * feat: added mattermost notification for holo-auto-installer * feat: removed un-used imports * feat: removed non snake case error * Merge/updated structure into invoice pr (#52) * jurisdictions and categories struct compat with HHA * linting * don't panic if none * lint * hpos_hc_connect: bump to latest * update flake.nix * holochain v0.4.0-dev.1 (#47) * get_happ_preferences: update payload * clippy * edit names * clean up & restructure * move hbs types * import download_file from hpos_hc_connect * inline doc touch-ups * clean up comments * merge clean-up * Update/clean up (#49) * edit names * clean up & restructure * move hbs types * import download_file from hpos_hc_connect * inline doc touch-ups * clean up comments * Update src/types/hbs.rs Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com> * import core app types from hpos_hc_connect * remove option from kyc * edit comments --------- Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com> --------- Co-authored-by: Alastair Ong <alastair.ong@holo.host> Co-authored-by: peeech <pj@imagine-nyc.com> Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com> * feat: cargo fmt --------- Co-authored-by: Zeeshan Abid <zeeshan.abid.com@gmail.com> Co-authored-by: Lisa Jetton <ldjetton21@gmail.com> Co-authored-by: Alastair Ong <alastair.ong@holo.host> Co-authored-by: peeech <pj@imagine-nyc.com> Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com>

…#54) * feat: added invoice due date from note * feat: imports clean up * edit names * clean up & restructure * move hbs types * import download_file from hpos_hc_connect * inline doc touch-ups * feat: added mattermost notification for holo-auto-installer * feat: removed un-used imports * clean up comments * merge clean-up * feat: removed non snake case error * Merge/updated structure into invoice pr (#52) * jurisdictions and categories struct compat with HHA * linting * don't panic if none * lint * hpos_hc_connect: bump to latest * update flake.nix * holochain v0.4.0-dev.1 (#47) * get_happ_preferences: update payload * clippy * edit names * clean up & restructure * move hbs types * import download_file from hpos_hc_connect * inline doc touch-ups * clean up comments * merge clean-up * Update/clean up (#49) * edit names * clean up & restructure * move hbs types * import download_file from hpos_hc_connect * inline doc touch-ups * clean up comments * Update src/types/hbs.rs Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com> * import core app types from hpos_hc_connect * remove option from kyc * edit comments --------- Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com> --------- Co-authored-by: Alastair Ong <alastair.ong@holo.host> Co-authored-by: peeech <pj@imagine-nyc.com> Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com> * feat: cargo fmt * clean-up suspended disable flow * edit comment --------- Co-authored-by: Zeeshan Abid <zeeshan.abid.com@gmail.com> Co-authored-by: Alastair Ong <alastair.ong@holo.host> Co-authored-by: peeech <pj@imagine-nyc.com> Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com>

JettTech added 3 commits July 7, 2024 15:55

edit names

0069b48

Merge branch 'main' into update/clean-up-names

57f356e

clean up & restructure

626cbdb

JettTech requested a review from zo-el as a code owner July 8, 2024 08:25

JettTech added 3 commits July 8, 2024 03:40

move hbs types

b274874

import download_file from hpos_hc_connect

6eb9b6b

inline doc touch-ups

1798e6e

pegaltier reviewed Jul 8, 2024

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

clean up comments

2540a01

JettTech mentioned this pull request Jul 8, 2024

Merge invoice-due-date into updated structure #51

Closed

zo-el reviewed Jul 10, 2024

View reviewed changes

zo-el approved these changes Jul 10, 2024

View reviewed changes

Update src/types/hbs.rs

4b4e2a1

Co-authored-by: Joel Ulahanna <joelulahanna@gmail.com>

JettTech mentioned this pull request Jul 10, 2024

feature: add core_app zome calls Holo-Host/hpos-service-crates#191

Merged

JettTech added 4 commits July 10, 2024 12:23

import core app types from hpos_hc_connect

3794615

Merge branch 'update/clean-up' of github.com:Holo-Host/holo-auto-inst…

1ee6265

…aller into update/clean-up

remove option from kyc

215ce09

edit comments

ee5c274

JettTech merged commit 713a176 into main Jul 10, 2024
2 checks passed

JettTech deleted the update/clean-up branch July 10, 2024 18:03

JettTech mentioned this pull request Jul 10, 2024

Merge/updated structure into invoice pr #52

Merged

JettTech added a commit to Holo-Host/hpos-service-crates that referenced this pull request Jul 10, 2024

feature: add core_app zome calls (#191)

f922ed2

### Updates: - Adds the zome calls in response to the suggestion from the [holo-auto-installer pr #49](Holo-Host/holo-auto-installer#49)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update/clean up #49

Update/clean up #49

JettTech commented Jul 8, 2024 •

edited

Loading

zo-el Jul 10, 2024

JettTech Jul 10, 2024

zo-el Jul 10, 2024

JettTech Jul 10, 2024

zo-el Jul 10, 2024

JettTech Jul 10, 2024 •

edited

Loading

Update/clean up #49

Update/clean up #49

Conversation

JettTech commented Jul 8, 2024 • edited Loading

Updates:

zo-el Jul 10, 2024

Choose a reason for hiding this comment

JettTech Jul 10, 2024

Choose a reason for hiding this comment

zo-el Jul 10, 2024

Choose a reason for hiding this comment

JettTech Jul 10, 2024

Choose a reason for hiding this comment

zo-el Jul 10, 2024

Choose a reason for hiding this comment

JettTech Jul 10, 2024 • edited Loading

Choose a reason for hiding this comment

JettTech commented Jul 8, 2024 •

edited

Loading

JettTech Jul 10, 2024 •

edited

Loading