Support GetAll for ethernet resource #313
Conversation
|
|
||
| } | ||
| file, _ := json.MarshalIndent(elist, "", " ") | ||
| file_name := fmt.Sprintf("test_check_%d.json", 5) |
There was a problem hiding this comment.
don't use underscores in Go names; var file_name should be fileName
|
|
||
| initialScopeUris := make([]utils.Nstring, len(eNetList.Members[i].InitialScopeUris)) | ||
| for _, scope := range eNetList.Members[i].InitialScopeUris { | ||
| initialScopeUri := utils.Nstring(scope.String()) |
There was a problem hiding this comment.
var initialScopeUri should be initialScopeURI
| d.SetId("") | ||
| return nil | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block
| if err != nil { | ||
| d.SetId("") | ||
| return nil | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block
| file, _ := json.MarshalIndent(members, "", " ") | ||
| _ = ioutil.WriteFile("test.json", file, 0644) | ||
|
|
||
| d.SetId(string(file)) |
There was a problem hiding this comment.
The setting part will not set the count and next page uri?
| d.SetId(name) | ||
| return nil | ||
|
|
||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block
| "github.com/hashicorp/terraform-plugin-sdk/helper/schema" | ||
| ) | ||
|
|
||
| func EthernetSchema() *schema.Resource { |
There was a problem hiding this comment.
exported function EthernetSchema should have comment or be unexported
| @@ -0,0 +1,99 @@ | |||
| package common_schema | |||
There was a problem hiding this comment.
don't use an underscore in package name
Description
Support GetAll for ethernet resource
Issues Resolved
Check List