Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding method is_connected() to CFMClient class #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Edrusb
Copy link

@Edrusb Edrusb commented Feb 20, 2020

this is based on the value of the _auth_token field

this is based on the value of the _auth_token field
@netmanchris
Copy link
Collaborator

@Edrusb This isn't attached to any GITHUB issue. Can you please open an issue and explain why we need this change?

Almost might need to you make a small change ( add white space or something ) Travis-CI didn't trigger a build of this PR so can't validate whether or not any breaking changes were introduced.

@netmanchris netmanchris added the enhancement New feature or request label Feb 20, 2020
@Edrusb
Copy link
Author

Edrusb commented Feb 20, 2020

@netmanchris, There is no issue. Just found interesting to get the status of connection (whether a token could be retrieved from the CFM). I realize that the token may exist and become outdated for the CFM, So maybe the name "is_connected" is not the best choice, and you can change to CamelNotation if you prefer

@netmanchris
Copy link
Collaborator

I realize there's no issue. That's why I asked you to please create one. :) . I'll add a section on making PRs to the docs as well for contributors. Process has been to create issues for any new functionality, or bugs so that we have something we can attach the PRs to and we have full transparency for the product. I'll add a section for contributing to detail what's expected. As well, any PR needs to pass the tests before being merged so I need to figure out why your PR didn't trigger a TRAVIS build. I'll open an issue for that.

@Edrusb
Copy link
Author

Edrusb commented Feb 20, 2020

I did not intend to bypass any process nor create load for anyone (this is rather the opposite intention of PR within github: let maintainer receive ready to use code that they can accept, amend or refuse without having to give write access to the git repository to anyone.

Sorry for the extra work created by those few proposed lines! Maybe adding a " Code of conduct" a "Contributing" to the repository could help in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants