Stop dispatching onFocus when debugger is not visible #3271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an issue where closing the debugger would dispatch an
onFocus
event.One of the issues caused by this issue is sounds playing after the debugger gets closed.
If you play a sound, pause it, open the debugger and then close it, the sound will get unpaused and continue playing.
This code seems to have been added for a reason but I can't reproduce what the comment is saying. setting
FlxG.stage.focus = null;
doesn't seem to dispatch any focus events. Maybe its an old OpenFL version thing? Or target specific?