made buttons into anchor tags

HarveyD · Jan 7, 2019 · 66cfcb9 · 66cfcb9
1 parent 383d4b0
commit 66cfcb9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/components/shared/project-modal/project-modal.scss b/components/shared/project-modal/project-modal.scss
@@ -99,8 +99,9 @@
             border: none;
             transition: 0.25s background-color ease-in-out;
             cursor: pointer;
+            text-decoration: none;
 
-            .fa {
+            .fa, .fab {
               padding-left: 0.35rem;
             }
           }
@@ -152,7 +153,7 @@
       overflow: hidden;
 
       .modal-body-container {
-        flex: none;
+        flex: 4;
 
         .header-container {
           margin: 0;

diff --git a/components/shared/project-modal/project-modal.tsx b/components/shared/project-modal/project-modal.tsx
@@ -20,22 +20,20 @@ const renderTechnologies = (skillList: SkillEnum[]) =>
 const renderButtons = (url: IUrl) => (
   <div className="button-links">
     {url.github && (
-      <button
-        onClick={() => window.open(url.github)}
+      <a href={url.github}
         className="link-button button-github"
       >
         Github
-        <i className="fa fa-github" />
-      </button>
+        <i className="fab fa-github" />
+      </a>
     )}
     {url.website && (
-      <button
-        onClick={() => window.open(url.website)}
+      <a href={url.website}
         className="link-button button-website"
       >
         Website
         <i className="fa fa-link" />
-      </button>
+      </a>
     )}
   </div>
 );