Skip to content
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.

Add MotherboardUpdateRequest #357

Merged
merged 12 commits into from
Dec 23, 2017

Conversation

renatomassaro
Copy link
Member

@renatomassaro renatomassaro commented Dec 7, 2017

TODO

Incidental

  • Renamed channel/socket assignment access_type to access.
  • Removed deprecated DB scheme from Cache (introduced at Hardware refactor #338).

This change is Reviewable

@renatomassaro
Copy link
Member Author

Reviewed 54 of 54 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks broke.


lib/entity/henforcer/entity.ex, line 83 at r1 (raw file):

    {true, owns_component_relay}
    | owns_component_error
  def owns_component?(entity_id = %Entity.ID{}, component, owned) do

Doc henforcers


lib/server/event/motherboard.ex, line 5 at r1 (raw file):

  import Helix.Event

  event Updated do

doc everywhere


lib/server/henforcer/component.ex, line 1 at r1 (raw file):

defmodule Helix.Server.Henforcer.Component do

docdocdoc


lib/server/henforcer/server.ex, line 22 at r1 (raw file):

  Ensures the requested server exists on the database.
  """
  # TODO: REVIEW: Why does it accept `Server.t` as input?

Reviewed. Remove.


lib/server/public/server.ex, line 57 at r1 (raw file):

  ::
    ServerFlow.update_mobo_result
  def update_mobo(server, {mobo, components, ncs}, entity_ncs, relay) do

doc


lib/server/websocket/channel/server.ex, line 130 at r1 (raw file):

  @doc """
  Errors:

Missing params and return sections


Comments from Reviewable

@sourcelevel-bot
Copy link

Ebert has finished reviewing this Pull Request and has found:

  • 2 possible new issues (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/357.

@renatomassaro
Copy link
Member Author

Reviewed 12 of 13 files at r2, 7 of 7 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@renatomassaro renatomassaro merged commit bb967a9 into HackerExperience:master Dec 23, 2017
@renatomassaro renatomassaro deleted the hw-requests branch December 23, 2017 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant