-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update QC metrics in mzML files example #228
Conversation
Sounds good to me. We can add the |
Updated CV term requested in psi-ms-CV#304. This PR should be merged after #219. |
There's still one small issue with this example. The spectra half-TIC metric that we're using is defined for MS2 spectra in the CV, but in this mzML file the three spectra are actually MS1 spectra. So semantically this is invalid, although no parser will flag this issue.
Should we?