Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update QC metrics in mzML files example #228

Merged
merged 15 commits into from
Jul 29, 2024
Merged

update QC metrics in mzML files example #228

merged 15 commits into from
Jul 29, 2024

Conversation

bittremieux
Copy link
Collaborator

There's still one small issue with this example. The spectra half-TIC metric that we're using is defined for MS2 spectra in the CV, but in this mzML file the three spectra are actually MS1 spectra. So semantically this is invalid, although no parser will flag this issue.

Should we?

  • Update the mzML file to contain MS2 spectra instead. This will be confusing imo, because to be valid, there also needs to be an MS1 spectrum first and then we need to explain this tricky difference.
  • Remove the "MS2 metric" relationship and have this term instead be applicable to any level of MS. This works reasonably I think, the only issue could be that the metric is not really informative for profile spectra (which are typically MS1).

@bittremieux bittremieux changed the base branch from main to intro_set July 9, 2024 10:10
@bittremieux bittremieux mentioned this pull request Jul 9, 2024
7 tasks
@cbielow
Copy link
Collaborator

cbielow commented Jul 9, 2024

Remove the "MS2 metric" relationship and have this term instead be applicable to any level of MS. This works reasonably I think, the only issue could be that the metric is not really informative for profile spectra (which are typically MS1).

Sounds good to me. We can add the requires centroided peaks requirement in the description (or maybe even as an attribute?)

@bittremieux bittremieux changed the base branch from intro_set to main July 24, 2024 13:51
@bittremieux
Copy link
Collaborator Author

bittremieux commented Jul 24, 2024

Updated CV term requested in psi-ms-CV#304.

This PR should be merged after #219.

This was linked to issues Jul 25, 2024
@bittremieux bittremieux merged commit 3ccfca9 into main Jul 29, 2024
1 check passed
@bittremieux bittremieux deleted the mzml_example branch July 29, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update examples to mzQC v1.0 Remove QC CV from markup docs
2 participants