Updating relay settings type to allow for filtering through relay set… #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tings for leaf file types.
… for these in our relay panel stats.
|
Just an initial thought so I don't forget later but I believe this would be best implemented into the canUpload function of the upload handler or something along these lines as it would need to directly deny the upload if the relay doesn't allow it, this can't be done in the database code as it would be too late (we wouldn't want someone to upload an entire file just to have it rejected after). I will take care of the implementation in a bit, thanks for making this part @Maphikza, makes my life a lot easier. |
|
Leaving this here for the moment but it's actually been made redundant by some of my recent changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tings for leaf file types.
The IsFilePermitted function will make our panel settings effective in the relay. We can apply it on our upload functions.