Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds back the doors to the City #242

Merged
merged 5 commits into from
Nov 10, 2024
Merged

Adds back the doors to the City #242

merged 5 commits into from
Nov 10, 2024

Conversation

Hazado
Copy link
Contributor

@Hazado Hazado commented Aug 13, 2023

Script files - H-uru/Plasma#1462

Adds back the doors to the city age
Library - https://www.youtube.com/watch?v=eQN9g3_GvGw
Museum - https://youtu.be/cKd7t_hcM-A

Added actual collisions to the doors
Moved the exclusion region on/off to the beginning of the responder

These changes make it so your not running into invisible barriers when the door is opening. When the door is closing you will notice invisible barrier a little bit, but without that I was able to be pushed through the wall and fall through the ground to the basement. I feel that these changes make the doors a better experience than what happens in CC.

@Hazado Hazado changed the title Adds back the doors to the library Adds back the doors to the City library Aug 13, 2023
@patmauro
Copy link
Contributor

Working great on the test server so far after the sound fix! :) Looks like this, along with H-uru/Plasma#1462, should partially resolve #33.

@Hazado Hazado changed the title Adds back the doors to the City library Adds back the doors to the City Aug 22, 2023
@patmauro patmauro mentioned this pull request Nov 5, 2024
@Hoikas Hoikas added enhancement New feature or request objective An issue or fix that is a clear defect or improvement labels Nov 10, 2024
Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for restoring these doors! I took the liberty of changing the museum doors to respect the value of the SDL variable islmMuseumDoorFunc. There is no corresponding variable for the library doors, so I left that one alone.

@Hoikas Hoikas merged commit dbc7d93 into H-uru:master Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request objective An issue or fix that is a clear defect or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the Ae'gura museum/library doors Fix the city doors (library & museum)
3 participants