Added russian translation #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgelessus
reviewed
Jun 20, 2023
There was a problem hiding this comment.
Looks good overall from the technical side. A few small comments below.
Unfortunately there are still some rendering problems in the journals. For example, in Yeesha's ABM book (on the Relto bookshelf) and the credits, every double page has only one line of text on it. The KI/Nexus journal works better, but has random blank pages in the middle of the text.
I don't know if this is another font size problem or a bug in the text wrapping logic. I'll see if I can debug this. We should wait with merging until we know the font files are okay.
compiled/sfx/clftEdog02_rus.sub
Outdated
| @@ -0,0 +1,3 @@ | |||
| 1 | |||
| 00:00:00,000 --> 00:00:03,200 | |||
| Занди: Ух ты! Жарко, но это сухая жара. | |||
There was a problem hiding this comment.
Minor thing: some of the .sub files are missing a final newline.
There was a problem hiding this comment.
Didn't knew it needs one. Will fix it.
| <translation language="Russian">Эпохи во владении</translation> | ||
| </element> | ||
| <element name="AllPlayers"> | ||
| <translation language="Russian">Все игроки</translation> |
There was a problem hiding this comment.
This is the same translation as "Age Players" (AgeMembers) - they should be different. "All Players" is a list of all players on the entire server, not just the current age. (Normally, only admins can see this list.)
|
By the way, can somebody who's not me try to checkout this branch, to confirm that the LFS upload worked? (I have the missing files added locally now, even though they aren't on the GoW LFS server, so I can't check properly anymore.) |
|
@Fairyon A few messages are translated in the engine code and not in .loc files. Can you translate these as well? Thanks!
You can just comment the translations here - I'll integrate them with my other code changes. |
dgelessus
added a commit
to dgelessus/Plasma
that referenced
this pull request
Jun 20, 2023
Translations submitted by @Fairyon: H-uru/moul-assets#237
|
|
Great work, @Fairyon! Thanks for providing this. :) |
|
Good news: the journal rendering bug isn't caused by this PR, so I would say it's not a blocker for merging this. Bad news: the bug also affects other languages, e. g. French, with the current master branches of Plasma and moul-assets. I have no idea what causes it and I'm not even sure how long the bug has existed already - clearly we don't test the translations very much 😟 I'll make a separate issue and/or PR once I've figured out more. |
IIRC this came up in testing of Kalamee's credits journal translation too (on an OU client, I think?) |
Hoikas
added
enhancement
Hoikas
reviewed
Jun 25, 2023
There was a problem hiding this comment.
It looks like there are some translations for Ages that haven't been accepted yet:
These probably need to be strippped out of this PR and shared with the author of the Ages (CC @ametist365, @DoobesURU).
I'm a little nervous about accepting manual edits to the .p2f files, but it's probably ok until we improve plFontConverter to convert more ranges of characters.
compiled/dat/ACARussian.loc
Outdated
| @@ -0,0 +1,336 @@ | |||
| <?xml version="1.0" encoding="utf-16"?> | |||
There was a problem hiding this comment.
Suggested change
| <?xml version="1.0" encoding="utf-16"?> | |
| <?xml version="1.0" encoding="utf-8"?> |
|
The next move for this, I think, is to verify that everything works as expected when this is shipped with a client that allows Russian to be selected. That means I need to deploy a new Troll Land build... Then, we should be good to go with this :) |
|
This looks really good on TrollLand so far! There are a few things that still need to be translated. This will help us get the StartUp Age consistently in Russian.
The engine tells me that they are: There are more things that need translation, but those are the most important. I think it would be good to also have the note in the Chiso book translated as well :)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and accept this request to make the russian language for basic Ages of URU available :)